Add support to select supplier for a given type#31292
Merged
Merged
Conversation
7e26283 to
d258379
Compare
stianst
commented
Jul 15, 2024
Contributor
Author
There was a problem hiding this comment.
Temporary until we have Smallrye config stuff in place, but this let's you define the supplier using system property, environment variable, or in .env file.
Example of the last one:
# cat ./test-poc/base/.env
KC_TEST_BROWSER=firefox
KC_TEST_SERVER=remote
jonkoops
reviewed
Jul 15, 2024
Contributor
There was a problem hiding this comment.
supplier.getValueType() is called 4 times in this loop, perhaps re-use it in a variable?
Contributor
There was a problem hiding this comment.
This is always true, as it matches the condition of the if it is contained in.
Suggested change
| shouldAdd = !loadedValueTypes.contains(supplier.getValueType()); | |
| shouldAdd = true; |
d258379 to
de1e1c5
Compare
miquelsi
approved these changes
Jul 16, 2024
de1e1c5 to
32f3eb3
Compare
lhanusov
reviewed
Jul 16, 2024
Contributor
There was a problem hiding this comment.
@stianst Since TestDatabase is merged, I propose to rebase it and add a database support here as well with particular aliases. WDYT?
Closes keycloak#30609 Signed-off-by: stianst <stianst@gmail.com>
32f3eb3 to
49e5cf9
Compare
miquelsi
approved these changes
Jul 16, 2024
lhanusov
approved these changes
Jul 16, 2024
lhanusov
left a comment
Contributor
There was a problem hiding this comment.
thank you Stian for updating the code, LGTM 👍
stianst
added a commit
to stianst/keycloak
that referenced
this pull request
Jul 25, 2024
Closes keycloak#30609 Signed-off-by: stianst <stianst@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Few things related to this:
Closes #30609
Signed-off-by: stianst stianst@gmail.com