Conversation
* Admin REST resources: changes boolean and integer arguments with default values to basic java in order to fix openapi errors * fix getClientRoleComposites endpoint path param client-uuid by renaming it to child-client-uuid Closes keycloak#40400 Signed-off-by: Maëlick Claes <maelick.claes@epiroc.com>
43354e0 to
cd71be0
Compare
|
Unfortunately the original issue was already closed due to lack of updates, but the concern remains valid. @maelick and @RiRa12621 please open new / more targeted issues. Note there has been a subsequent PR opened to address just the client-uuid issue #46016 The same considerations will be present for admin api v2 - and we are actively looking at alternative client implementation there #43167 including the go client so ideally we shouldn't hit these problems moving foward.
I believe the usage of object types is to be consistent with allowing for optional parameters. It should also allow for passing an explicit null. But as you say that doesn't mesh well with using a Default. Let's see if anyone else weighs in on whether updating the Default or changing to a primitive makes sense here. cc @keycloak/cloud-native |
Closes #40400
Note: I am unsure what is the reason behind using object types rather than primitive Java types for boolean and integer arguments. If the change has no impact on the Keycloak behavior, maybe it would be better to change them all to use the primitive types?