Skip to content

introduced related colors to the theme tab#45785

Open
edewit wants to merge 2 commits intokeycloak:mainfrom
edewit:issue-45527
Open

introduced related colors to the theme tab#45785
edewit wants to merge 2 commits intokeycloak:mainfrom
edewit:issue-45527

Conversation

@edewit
Copy link
Contributor

@edewit edewit commented Jan 27, 2026

This reduces the number of colors that the user has to set to make his
own theme, by having hover and or other colors be derived from a parent
color

fixes: #45527

Signed-off-by: Erik Jan de Wit erikjan.dewit@gmail.com

@edewit edewit requested review from a team as code owners January 27, 2026 12:35
@edewit
Copy link
Contributor Author

edewit commented Jan 27, 2026

image Changing the primary color will also change the dependent colors with a css "trick" to make them in the same tone, but there is still a possibility to override these defaults

@mabartos
Copy link
Contributor

@edewit Looks nice, but I found one bug. When you want to override the secondary color, even the primary color is changed.

Screencast.From.2026-01-28.17-08-31.mp4

@edewit
Copy link
Contributor Author

edewit commented Feb 2, 2026

@mabartos this is because in PF in light mode the secondary color and the primary color use the same variable, but that's not the case in dark mode. So I can't really do anything about that other then removing the secondary color selector for light mode

@mabartos
Copy link
Contributor

mabartos commented Feb 6, 2026

@mabartos this is because in PF in light mode the secondary color and the primary color use the same variable, but that's not the case in dark mode. So I can't really do anything about that other then removing the secondary color selector for light mode

Maybe it makes sense to just filter it out, because then it's very confusing. @edewit WDYT?

@edewit
Copy link
Contributor Author

edewit commented Feb 6, 2026

@mabartos create an issue for patternfly and commented it out for now

@mabartos
Copy link
Contributor

@edewit Could you please resolve the conflict? Thanks!

This reduces the number of colors that the user has to set to make his
own theme, by having hover and or other colors be derived from a parent
color

fixes: keycloak#45527

Signed-off-by: Erik Jan de Wit <erikjan.dewit@gmail.com>
…k mode

Signed-off-by: Erik Jan de Wit <erikjan.dewit@gmail.com>
Copy link
Contributor

@mabartos mabartos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@edewit Looks very good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[quick-theme] Show only the color settings for major color groups

2 participants