Update name field validation logic in NewClientPolicy component#46307
Open
calebd-anderson wants to merge 1 commit intokeycloak:mainfrom
Open
Update name field validation logic in NewClientPolicy component#46307calebd-anderson wants to merge 1 commit intokeycloak:mainfrom
NewClientPolicy component#46307calebd-anderson wants to merge 1 commit intokeycloak:mainfrom
Conversation
ae6f913 to
ac4d529
Compare
NewClientPolicy componentNewClientPolicy component
ac4d529 to
0ef2cd7
Compare
with the policyName constant only defined when editing, short-circuit the logic to only verify a new policy name has not been taken if policyName does not match the new name Closes keycloak#45948 Signed-off-by: Caleb Anderson <2682726+calebd-anderson@users.noreply.github.com>
0ef2cd7 to
575e916
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
NewClientPolicycomponent is reused for creating a client policy and editing an existing client policy. If the form is not valid the save button is disabled. This PR updates the name field form validation. Given thepolicyNameconstant is only defined when editing an existing client policy, short-circuit the validation logic to only verify the new policy name has not been taken ifpolicyNamedoes not match the new name.With this form validation logic, the expected behavior of the form is enabled:
Fixes:
When I save a client policy, the conditions and client profiles should be visibleCloses #45948