Handle resource IDs matching the resource type for "Enforce access to" -> "All"#47917
Merged
Conversation
martin-kanis
suggested changes
Apr 14, 2026
martin-kanis
left a comment
Contributor
There was a problem hiding this comment.
@dpiva97 Thanks for the PR. The fix seems to be correct, however we are missing a test. Probably, the simplest would be to add
createPermission(client, PermissionBuilder.create()
.resourceType(AdminPermissionsSchema.USERS.getType())
.resources(Set.of(AdminPermissionsSchema.USERS.getType()))
.scopes(AdminPermissionsSchema.USERS.getScopes())
.build());
createPermission(client, PermissionBuilder.create()
.resourceType(AdminPermissionsSchema.GROUPS.getType())
.resources(Set.of(AdminPermissionsSchema.GROUPS.getType()))
.scopes(AdminPermissionsSchema.GROUPS.getScopes())
.build());
createPermission(client, PermissionBuilder.create()
.resourceType(AdminPermissionsSchema.CLIENTS.getType())
.resources(Set.of(AdminPermissionsSchema.CLIENTS.getType()))
.scopes(AdminPermissionsSchema.CLIENTS.getScopes())
.build());
createPermission(client, PermissionBuilder.create()
.resourceType(AdminPermissionsSchema.ROLES.getType())
.resources(Set.of(AdminPermissionsSchema.ROLES.getType()))
.scopes(AdminPermissionsSchema.ROLES.getScopes())
.build());
into org.keycloak.tests.admin.authz.fgap.PermissionRESTTest#permissionsTest.
Can you add it please?
…" -> "All" Closes keycloak#47901 Signed-off-by: Davide Piva <davide.piva@intesys.it>
Author
|
Thanks @martin-kanis, I've rebased on main and added the tests |
vramik
approved these changes
Apr 15, 2026
pedroigor
approved these changes
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #47901