Explicitly navigate to application page in tests#233
Merged
jonkoops merged 1 commit intokeycloak:mainfrom Dec 9, 2025
Merged
Conversation
Closes keycloak#232 Signed-off-by: Jon Koops <jonkoops@gmail.com>
There was a problem hiding this comment.
Pull request overview
This PR modifies the test framework to require explicit navigation to the application page before adapter operations. Previously, the instantiateAdapter method automatically navigated to the app page if needed, which could mask test failures by allowing tests to pass even when they should fail.
Key Changes:
- Removed automatic page navigation from
instantiateAdapter()method - Added explicit
navigateToApp()method to TestExecutor - Updated all test files to explicitly call
navigateToApp()before first adapter operation
Reviewed changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| test/support/test-executor.ts | Removed #ensureOnAppPage() method and its automatic call; added public navigateToApp() method |
| test/tests/user-profile.spec.ts | Added explicit navigation calls before adapter operations |
| test/tests/user-info.spec.ts | Added explicit navigation calls before adapter operations |
| test/tests/token.spec.ts | Added explicit navigation calls before adapter operations |
| test/tests/silent-sso.spec.ts | Added explicit navigation calls before adapter operations |
| test/tests/scope.spec.ts | Added explicit navigation calls before adapter operations |
| test/tests/register-url.spec.ts | Added explicit navigation calls before adapter operations |
| test/tests/logout-url.spec.ts | Added explicit navigation calls before adapter operations |
| test/tests/login.spec.ts | Added explicit navigation calls before adapter operations |
| test/tests/login-with-redirect.spec.ts | Added explicit navigation calls before adapter operations |
| test/tests/login-url.spec.ts | Added explicit navigation calls before adapter operations |
| test/tests/init.spec.ts | Added explicit navigation calls before adapter operations |
| test/tests/implicit-flow.spec.ts | Added explicit navigation calls before adapter operations |
| test/tests/account-url.spec.ts | Added explicit navigation calls before adapter operations |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
rmartinc
approved these changes
Dec 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes the test executor, so that initial navigation to the application page only happens when done manually. This prevents automatic navigation later in the test that could cause a test to pass, even if should be failing.
Closes #232