adjust JWT API for forward token #12997
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: omar <omar.hammami@solo.io>
Copilot finished reviewing on behalf of
puertomontt
November 27, 2025 05:25
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the JWT Provider API to simplify token forwarding configuration. It replaces the enum-based KeepToken field (with Forward and Remove values) with a simpler boolean ForwardToken field, aligning better with the underlying Envoy JWT filter's forward field.
Key Changes:
- Changed API from enum-based
KeepToken *KeepTokento booleanForwardToken *bool - Updated implementation logic to check boolean value instead of enum comparison
- Removed
KeepTokentype and its constants (TokenForward,TokenRemove)
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| api/v1alpha1/jwt_types.go | Replaced KeepToken enum field with boolean ForwardToken field; removed KeepToken type definition and constants |
| api/v1alpha1/zz_generated.deepcopy.go | Updated generated DeepCopy code to handle boolean pointer instead of enum pointer |
| internal/kgateway/extensions2/plugins/trafficpolicy/jwt.go | Updated token forwarding logic to check boolean value instead of enum comparison |
| internal/kgateway/extensions2/plugins/trafficpolicy/jwt_test.go | Updated test cases to use boolean values instead of enum constants |
| install/helm/kgateway-crds/templates/gateway.kgateway.dev_gatewayextensions.yaml | Updated CRD schema to replace enum field with boolean field, including updated documentation |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
adjust JWT API for forward token
Change from enum to bool to better fit the underlying Envoy type forward.
Note: We haven't included this API in a release, but this is technically a breaking change for anyone that has been using the main or beta builds.
Change Type
/kind cleanup
Changelog
Additional Notes