Test and function improvements #274
dotnet.yml
on: pull_request
Build & Test
2m 5s
Code Quality Analysis
1m 36s
Annotations
20 warnings
|
Build & Test:
RaptorSheets.Core.Tests/Unit/Validators/SheetValidationHelpersTests.cs#L15
Argument of type '(string?, string)' cannot be used for parameter 'parameters' of type '(string value, string paramName)' in 'List<MessageEntity> SheetValidationHelpers.ValidateRequiredParameters(params (string value, string paramName)[] parameters)' due to differences in the nullability of reference types.
|
|
Build & Test:
RaptorSheets.Gig.Tests/Integration/GoogleSheetsIntegrationTests.cs#L550
Do not use Assert.NotNull() on value type 'DateTime'. Remove this assert. (https://xunit.net/xunit.analyzers/rules/xUnit2002)
|
|
Build & Test:
RaptorSheets.Gig.Tests/Unit/Mappers/MapToRangeDataTests.cs#L101
Cannot convert null literal to non-nullable reference type.
|
|
Build & Test:
RaptorSheets.Gig.Tests/Integration/GoogleSheetsIntegrationTests.cs#L126
This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.
|
|
Build & Test:
RaptorSheets.Gig.Tests/Integration/IntegrationTestFixture.cs#L101
The member 'TestableIntegrationBase.HasCredentials()' does not hide an accessible member. The new keyword is not required.
|
|
Build & Test:
RaptorSheets.Core.Tests/Unit/Validators/SheetValidationHelpersTests.cs#L45
Null should not be used for type parameter 'id' of type 'string'. Use a non-null value, or convert the parameter to a nullable type. (https://xunit.net/xunit.analyzers/rules/xUnit1012)
|
|
Build & Test:
RaptorSheets.Core.Tests/Unit/Helpers/SheetHelpersTests.cs#L622
Cannot convert null literal to non-nullable reference type.
|
|
Build & Test:
RaptorSheets.Core.Tests/Unit/Helpers/SheetHelpersTests.cs#L622
Cannot convert null literal to non-nullable reference type.
|
|
Build & Test:
RaptorSheets.Core.Tests/Unit/Helpers/SheetHelpersTests.cs#L621
Cannot convert null literal to non-nullable reference type.
|
|
Build & Test:
RaptorSheets.Core.Tests/Unit/Validators/SheetValidationHelpersTests.cs#L15
Argument of type '(string?, string)' cannot be used for parameter 'parameters' of type '(string value, string paramName)' in 'List<MessageEntity> SheetValidationHelpers.ValidateRequiredParameters(params (string value, string paramName)[] parameters)' due to differences in the nullability of reference types.
|
|
Code Quality Analysis:
RaptorSheets.Core.Tests/Unit/Helpers/SheetHelpersTests.cs#L622
Cannot convert null literal to non-nullable reference type.
|
|
Code Quality Analysis:
RaptorSheets.Core.Tests/Unit/Helpers/SheetHelpersTests.cs#L622
Cannot convert null literal to non-nullable reference type.
|
|
Code Quality Analysis:
RaptorSheets.Core.Tests/Unit/Helpers/SheetHelpersTests.cs#L621
Cannot convert null literal to non-nullable reference type.
|
|
Code Quality Analysis:
RaptorSheets.Core.Tests/Unit/Validators/SheetValidationHelpersTests.cs#L15
Argument of type '(string?, string)' cannot be used for parameter 'parameters' of type '(string value, string paramName)' in 'List<MessageEntity> SheetValidationHelpers.ValidateRequiredParameters(params (string value, string paramName)[] parameters)' due to differences in the nullability of reference types.
|
|
Code Quality Analysis:
RaptorSheets.Stock/Managers/GoogleSheetManager.cs#L66
Change this condition so that it does not always evaluate to 'False'. Some code paths are unreachable. (https://rules.sonarsource.com/csharp/RSPEC-2583)
|
|
Code Quality Analysis:
RaptorSheets.Stock/Managers/GoogleSheetManager.cs#L179
Complete the task associated to this 'TODO' comment. (https://rules.sonarsource.com/csharp/RSPEC-1135)
|
|
Code Quality Analysis:
RaptorSheets.Stock/Managers/GoogleSheetManager.cs#L111
Remove this commented out code. (https://rules.sonarsource.com/csharp/RSPEC-125)
|
|
Code Quality Analysis:
RaptorSheets.Stock/Managers/GoogleSheetManager.cs#L105
Remove this commented out code. (https://rules.sonarsource.com/csharp/RSPEC-125)
|
|
Code Quality Analysis:
RaptorSheets.Stock/Managers/GoogleSheetManager.cs#L56
Remove this commented out code. (https://rules.sonarsource.com/csharp/RSPEC-125)
|
|
Code Quality Analysis:
RaptorSheets.Core/Helpers/ConstantsOrderHelper.cs#L45
Loops should be simplified using the "Where" LINQ method (https://rules.sonarsource.com/csharp/RSPEC-3267)
|