fix checking for correct formatter in durationDecimal#5943
Merged
kevinpapst merged 1 commit intoMay 12, 2026
Merged
Conversation
e53a8a2 to
de94f11
Compare
kevinpapst
approved these changes
May 12, 2026
kevinpapst
left a comment
Member
There was a problem hiding this comment.
Good catch, thanks @cheriimoya 👍
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5943 +/- ##
=========================================
Coverage 87.90% 87.90%
Complexity 9840 9840
=========================================
Files 876 876
Lines 31484 31484
=========================================
Hits 27675 27675
Misses 3809 3809
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
LocaleFormatter::durationDecimal()guarded the lazy initialization of$this->decimalFormatterwith the wrong property ($this->numberFormatterinstead of$this->decimalFormatter). Ifamount()was called beforedurationDecimal()on the same formatter instance,$this->numberFormatterwould already be set, the guard would pass,$this->decimalFormatterwould never be initialized, and the subsequent->format()call would fail on null.Types of changes
Checklist
composer code-check)