Skip to content

fix adding an empty space in the delete modals#5962

Merged
kevinpapst merged 1 commit into
kimai:mainfrom
helsinki-systems:fix/spacing-in-delete-modal
Jun 1, 2026
Merged

fix adding an empty space in the delete modals#5962
kevinpapst merged 1 commit into
kimai:mainfrom
helsinki-systems:fix/spacing-in-delete-modal

Conversation

@cheriimoya

Copy link
Copy Markdown
Contributor

Description

Currently, there is a space missing in the message when trying to delete an activity/user/project:
image

With this patch, we get a space:
image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I verified that my code applies to the guidelines (composer code-check)
  • I updated the documentation (see here)
  • I agree that this code is used in Kimai (see license)

@codecov

codecov Bot commented Jun 1, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.33%. Comparing base (31a8f88) to head (256d236).

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #5962      +/-   ##
============================================
- Coverage     88.33%   88.33%   -0.01%     
  Complexity     9927     9927              
============================================
  Files           881      881              
  Lines         31717    31717              
============================================
- Hits          28017    28016       -1     
- Misses         3700     3701       +1     

see 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kevinpapst kevinpapst left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's an eagle-eye fix 😁
Thanks 👍

@kevinpapst kevinpapst merged commit c78a9dc into kimai:main Jun 1, 2026
9 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants