Skip to content

Improve whitespace handling in Search term parser#5977

Merged
kevinpapst merged 2 commits into
release-2.60from
metasearch
Jun 10, 2026
Merged

Improve whitespace handling in Search term parser#5977
kevinpapst merged 2 commits into
release-2.60from
metasearch

Conversation

@kevinpapst

Copy link
Copy Markdown
Member

Description

Do not explode by but on all whitespace character.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I verified that my code applies to the guidelines (composer code-check)
  • I updated the documentation (see here)
  • I agree that this code is used in Kimai (see license)

@kevinpapst kevinpapst marked this pull request as ready for review June 10, 2026 09:56
@codecov

codecov Bot commented Jun 10, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 88.44%. Comparing base (6c245ef) to head (28ac061).

Files with missing lines Patch % Lines
src/Utils/SearchTerm.php 66.66% 1 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                 @@
##             release-2.60    #5977      +/-   ##
==================================================
+ Coverage           88.42%   88.44%   +0.01%     
- Complexity           9970     9971       +1     
==================================================
  Files                 885      885              
  Lines               31827    31830       +3     
==================================================
+ Hits                28143    28152       +9     
+ Misses               3684     3678       -6     
Files with missing lines Coverage Δ
src/Repository/Search/SearchHelper.php 90.69% <100.00%> (+11.87%) ⬆️
src/Utils/SearchTerm.php 95.00% <66.66%> (-2.37%) ⬇️

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kevinpapst kevinpapst changed the title Metasearch Improve whitespace handling in Search term parser Jun 10, 2026
@kevinpapst kevinpapst merged commit bed9fe3 into release-2.60 Jun 10, 2026
11 checks passed
@kevinpapst kevinpapst deleted the metasearch branch June 10, 2026 10:02
@kevinpapst kevinpapst mentioned this pull request Jun 10, 2026
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant