fix: Fix auto_discover paths, allow inline auto_discover #802
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My previous PR somehow did not work entirely as intended. The DEPLOY_CONFIG_BASE_DIR path logic was leading to
working_dirbeing duplicated in the path. I have tried to implement a proper fix and add some tests to address this.Additionally, I've updated the POLL_CONFIG logic to also add support for auto_discover (the working_dir was not properly working there because it was being passed through 1:1).
Feel free to make any modifications that you feel are necessary and thanks for merging my previous PR!