Skip to content

fix(auto-discovery): fix cloneUrl comparison for auto-delete in webhook logic #812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kimdre merged 1 commit into from
Nov 25, 2025
Merged

fix(auto-discovery): fix cloneUrl comparison for auto-delete in webhook logic #812

kimdre merged 1 commit into from
Nov 25, 2025

Conversation

@kimdre
Copy link
Owner

@kimdre kimdre commented Nov 25, 2025 •
edited
Loading

fixes #813

@kimdre kimdre added the bug Something isn't working label Nov 25, 2025
@codecov
Copy link

codecov bot commented Nov 25, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 40.27%. Comparing base (a7f7688) to head (5da162c).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
cmd/doco-cd/handler_webhook.go 80.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #812      +/-   ##
==========================================
- Coverage   40.30%   40.27%   -0.04%     
==========================================
  Files          48       48              
  Lines        3689     3690       +1     
==========================================
- Hits         1487     1486       -1     
- Misses       1942     1943       +1     
- Partials      260      261       +1
Flag Coverage Δ
unittests 40.27% <80.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kimdre kimdre changed the title fix(auto-discovery): fix cloneUrl comparison for auto-discovery delete in webhook logic fix(auto-discovery): fix cloneUrl comparison for auto-delete in webhook logic Nov 25, 2025
@kimdre kimdre merged commit f4e7406 into main Nov 25, 2025
11 checks passed
@kimdre kimdre deleted the fix/cloneUrl-webhook branch November 25, 2025 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

cloneURL comparison not correct ?

2 participants

@kimdre