Skip to content

Conversation

@kimdre
Copy link
Owner

@kimdre kimdre commented Nov 30, 2025

When a deployConfig triggers consecutive deployments for a repository with the same commit sha, the forceDeploy flag will now be set to true to make Docker do a forced stack/project deployment.
Use the new appConfig setting MAX_DEPLOYMENT_LOOP_COUNT (default: 3) to set, when the detection should set the forceDeploy. Set the option to 0, to disable the detection logic and never set forceDeploy.

@kimdre kimdre added the enhancement Improvements or additions to code label Nov 30, 2025
@kimdre kimdre linked an issue Nov 30, 2025 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Nov 30, 2025

Codecov Report

❌ Patch coverage is 60.00000% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 40.04%. Comparing base (ef4fde1) to head (55bce59).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
cmd/doco-cd/handler_poll.go 33.33% 3 Missing and 1 partial ⚠️
cmd/doco-cd/handler_webhook.go 33.33% 3 Missing and 1 partial ⚠️
cmd/doco-cd/deploy.go 84.61% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #833      +/-   ##
==========================================
+ Coverage   39.99%   40.04%   +0.04%     
==========================================
  Files          48       49       +1     
  Lines        3733     3756      +23     
==========================================
+ Hits         1493     1504      +11     
- Misses       1975     1984       +9     
- Partials      265      268       +3     
Flag Coverage Δ
unittests 40.04% <60.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kimdre kimdre removed a link to an issue Nov 30, 2025
@kimdre kimdre linked an issue Nov 30, 2025 that may be closed by this pull request
@kimdre kimdre merged commit 46fe137 into main Nov 30, 2025
11 checks passed
@kimdre kimdre deleted the fix/788-infinite-redeployment-loop branch November 30, 2025 11:43
dfunkt added a commit to dfunkt/doco-cd that referenced this pull request Dec 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Improvements or additions to code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

infinite redeployment...

2 participants