Ensured that componets added after initialization are handled correctly.#258
Open
SleepProgger wants to merge 1 commit into
Open
Ensured that componets added after initialization are handled correctly.#258SleepProgger wants to merge 1 commit into
SleepProgger wants to merge 1 commit into
Conversation
Contributor
Author
|
Unrelated, but can we get the travis build fixed please ? Seem to be a problem with opengl libs ? |
Contributor
|
👍 awesome work here, this is an area that really needed to be fleshed out. I'll look into fixing the travis build. It seems to break reaaally frequently and then fix itself every now and then. Don't know that much about travis. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are multiple problems regarding components added by
create_component/ removed byremove_component.Components created via
create_componentaren't removed at thegameworld.remove_entitycall.Initial components removed by
remove_componentlead to a crash atgameworld.remove_entity.Duplicate components lead to memory leaks as the second component will overwrite the first one without any warning whatsoever.