chore(test): harmonise vitest coverage config with klodr/* ecosystem by klodr · Pull Request #172 · klodr/faxdrop-mcp

klodr · 2026-05-12T06:33:56Z

Summary

Replace the terse src/index.ts exclude comment with the canonical block shared across the klodr/* MCP suite (orchestration covered by tests lives in server.ts).
Drop the redundant src/**/*.d.ts entry — coverage include already restricts to src/**/*.ts, so declaration files cannot match.
Pure documentation / dead-entry cleanup, no behavioural change.

Test plan

npx vitest run --coverage passes locally (155 tests / 99.1% statements unchanged)

Summary by CodeRabbit

Chores
- Updated test coverage configuration to refine tracked files for coverage reporting.

Replace the terse `src/index.ts` exclude comment with the canonical explanation shared across the klodr/* MCP suite: the entry point is a thin shim around `StdioServerTransport`; testing it requires booting the transport, which deadlocks the runner. The orchestration covered by tests lives in `server.ts`. Also drop the redundant `src/**/*.d.ts` entry — coverage `include` already restricts to `src/**/*.ts`, so declaration files cannot match. Pure documentation / dead-entry cleanup, no behavioural change.

coderabbitai · 2026-05-12T06:34:06Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: a07defa5-0cae-447d-8894-8b62245dfaed

📥 Commits

Reviewing files that changed from the base of the PR and between 9415453 and 9fcdc7a.

📒 Files selected for processing (1)

vitest.config.ts

Walkthrough

The Vitest configuration coverage exclusions are refined by removing the src/**/*.d.ts pattern exclusion while explicitly keeping src/index.ts excluded. Comments are updated to clarify the exclusion rationale.

Changes

Coverage Configuration

Layer / File(s)	Summary
Coverage exclusion refinement `vitest.config.ts`	Coverage exclusion list updated to remove `src/*/.d.ts` pattern and retain only `src/index.ts`, with inline comments adjusted to clarify the rationale for excluding the CLI entry point.

🎯 2 (Simple) | ⏱️ ~5 minutes

Suggested labels

Review effort 2/5

🚥 Pre-merge checks | ✅ 4

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title follows Conventional Commits format with type 'chore', scope 'test', imperative mood subject, no trailing period, and is 68 characters—within the 72-character limit.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch chore/harmonize-vitest-coverage

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

codecov · 2026-05-12T06:34:25Z

Bundle Report

Bundle size has no change ✅

codecov · 2026-05-12T06:34:45Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (9415453) to head (9fcdc7a).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files

@@            Coverage Diff            @@
##              main      #172   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           15        15           
  Lines          505       505           
  Branches       134       134           
=========================================
  Hits           505       505

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9415453...9fcdc7a. Read the comment docs.

github-actions · 2026-05-12T06:34:46Z

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ No major issues detected

github-actions · 2026-05-12T06:35:06Z

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review Possible Issue The PR removes `"src/*/.d.ts"` from the coverage exclude list, incorrectly assuming that the include pattern `src/*/.ts` excludes `.d.ts` files. In reality, glob pattern `src/*/.ts` matches `.d.ts` files because they end in `.ts`. Removing this exclusion will cause declaration files to be processed by the coverage instrumenter, potentially leading to parse errors (since `.d.ts` files contain only type declarations, not executable code) and inflated coverage metrics. This is a behavioural change that contradicts the PR's claim of no behavioural change. // `src/index.ts` is the stdio CLI entry point — a thin shim that // boots `StdioServerTransport`. Testing it requires booting a real // transport, which deadlocks the test runner waiting for the next // stdio frame. The orchestration the shim wraps lives in // `server.ts` and is covered there. exclude: ["src/index.ts"],

🤖 I have created a release *beep* *boop* --- ## [0.8.8](v0.8.7...v0.8.8) (2026-05-12) ### Fixed * **pre-commit:** call ./node_modules/.bin/lint-staged directly ([#168](#168)) ([470d528](470d528)) ### Changed * add leak-detect caller workflow ([#170](#170)) ([4939f3b](4939f3b)) * bump actions/checkout from 4.2.2 to 6.0.2 ([#164](#164)) ([d737937](d737937)) * **ci:** migrate leak-detect to GitHub App credentials ([#171](#171)) ([9415453](9415453)) * **deps:** bump libphonenumber-js from 1.13.0 to 1.13.1 in the production-dependencies group ([#166](#166)) ([5253647](5253647)) * fix four workflow errors (pinact, gitleaks, auto-merge, coderabbit) ([#175](#175)) ([e8342fc](e8342fc)) * **leak-detect:** re-pin reusable workflow to fix yq checksum SHA ([#174](#174)) ([a0059be](a0059be)) * **node:** align .npmrc rationale + bump .nvmrc to 22.22.2 (CVE floor) ([#167](#167)) ([7750046](7750046)) * **pre-commit:** warn on missing system tooling (yamllint) ([#162](#162)) ([c5876b7](c5876b7)) * **pre-push:** sync with canonical template (SC2034 + drop npm audit) ([#163](#163)) ([ede1572](ede1572)) * **scripts:** canonicalise sync-version with ecosystem ([#173](#173)) ([e06d303](e06d303)) * **test:** harmonise vitest coverage config with klodr/* ecosystem ([#172](#172)) ([93c305b](93c305b)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: klodr-release-please[bot] <282976459+klodr-release-please[bot]@users.noreply.github.com>

…172) ## Summary - Replace the terse `src/index.ts` exclude comment with the canonical block shared across the klodr/* MCP suite (orchestration covered by tests lives in `server.ts`). - Drop the redundant `src/**/*.d.ts` entry — coverage `include` already restricts to `src/**/*.ts`, so declaration files cannot match. - Pure documentation / dead-entry cleanup, no behavioural change. ## Test plan - [x] `npx vitest run --coverage` passes locally (155 tests / 99.1% statements unchanged)  ## Summary by CodeRabbit * **Chores** * Updated test coverage configuration to refine tracked files for coverage reporting. [![Review Change Stack](https://storage.googleapis.com/coderabbit_public_assets/review-stack-in-coderabbit-ui.svg)](https://app.coderabbit.ai/change-stack/klodr/faxdrop-mcp/pull/172)

🤖 I have created a release *beep* *boop* --- ## [0.8.8](v0.8.7...v0.8.8) (2026-05-12) ### Fixed * **pre-commit:** call ./node_modules/.bin/lint-staged directly ([#168](#168)) ([25f44d9](25f44d9)) ### Changed * add leak-detect caller workflow ([#170](#170)) ([fc3d963](fc3d963)) * bump actions/checkout from 4.2.2 to 6.0.2 ([#164](#164)) ([510dcee](510dcee)) * **ci:** migrate leak-detect to GitHub App credentials ([#171](#171)) ([ed3d452](ed3d452)) * **deps:** bump libphonenumber-js from 1.13.0 to 1.13.1 in the production-dependencies group ([#166](#166)) ([9acac6c](9acac6c)) * fix four workflow errors (pinact, gitleaks, auto-merge, coderabbit) ([#175](#175)) ([8b127e8](8b127e8)) * **leak-detect:** re-pin reusable workflow to fix yq checksum SHA ([#174](#174)) ([e8fbcf2](e8fbcf2)) * **node:** align .npmrc rationale + bump .nvmrc to 22.22.2 (CVE floor) ([#167](#167)) ([38ed902](38ed902)) * **pre-commit:** warn on missing system tooling (yamllint) ([#162](#162)) ([aa2f198](aa2f198)) * **pre-push:** sync with canonical template (SC2034 + drop npm audit) ([#163](#163)) ([5fd4593](5fd4593)) * **scripts:** canonicalise sync-version with ecosystem ([#173](#173)) ([a157527](a157527)) * **test:** harmonise vitest coverage config with klodr/* ecosystem ([#172](#172)) ([3dd2876](3dd2876)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: klodr-release-please[bot] <282976459+klodr-release-please[bot]@users.noreply.github.com>

klodr enabled auto-merge (squash) May 12, 2026 06:34

github-actions Bot added the Review effort 1/5 label May 12, 2026

coderabbitai Bot approved these changes May 12, 2026

View reviewed changes

klodr merged commit 93c305b into main May 12, 2026
22 of 24 checks passed

klodr deleted the chore/harmonize-vitest-coverage branch May 12, 2026 06:35

coderabbitai Bot mentioned this pull request May 12, 2026

chore(scripts): canonicalise sync-version with ecosystem #173

Merged

3 tasks

klodr-release-please Bot mentioned this pull request May 12, 2026

chore(main): release 0.8.8 #169

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

chore(test): harmonise vitest coverage config with klodr/* ecosystem#172

chore(test): harmonise vitest coverage config with klodr/* ecosystem#172
klodr merged 1 commit into
mainfrom
chore/harmonize-vitest-coverage

klodr commented May 12, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented May 12, 2026 •

edited

Loading

Uh oh!

codecov Bot commented May 12, 2026

Uh oh!

codecov Bot commented May 12, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented May 12, 2026

Uh oh!

github-actions Bot commented May 12, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

klodr commented May 12, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Test plan

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented May 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Suggested labels

Uh oh!

codecov Bot commented May 12, 2026

Bundle Report

Uh oh!

codecov Bot commented May 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

github-actions Bot commented May 12, 2026

PR Reviewer Guide 🔍

Uh oh!

github-actions Bot commented May 12, 2026

PR Reviewer Guide 🔍

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

klodr commented May 12, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented May 12, 2026 •

edited

Loading

codecov Bot commented May 12, 2026 •

edited

Loading