Support bigint mode when using better-sqlite3
#6328
+133
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #5482, fixes #6319
This change adds support for selecting how to treat integers (number or bigint) when using
better-sqlite3. Adds code, documentation, and tests for using the knex factory's client options and query builder.optionsmethod to enable or disable numbers-as-bigints.Further work incoming, but this is useful out of the box and isolated; some of the other work involves trickier refactoring.
Open question: should we use the property
defaultSafeIntegersin the factory options? This is not a pass-through option to the driver no matter what it is named, so here I've kept it with the namesafeIntegersin both places it's used.Related: #6327
DRI:@myndzi