Wordwrapping fix #273
Open
Wordwrapping fix #273
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
English words are made up of multiple 1-byte characters, and they need to be wrapped by word, not by characters. The current logic wraps whenever the accumulated character width exceeds the region width — no regard for spaces or full words. This leads to words being split awkwardly in the middle. Implemented word wrapping instead of character wrapping, replaced garbage like "±¼¸²" with Arial.
they were too wide so I reverted them and everything seems to be fine again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
English words are made up of multiple 1-byte characters, and they need to be wrapped by word, not by characters.
The current logic wraps whenever the accumulated character width exceeds the region width — no regard for spaces or full words.
This leads to words being split awkwardly in the middle. Implemented word wrapping instead of character wrapping, replaced garbage like "±¼¸²" with Arial.
🚨 Checklist for this Pull Request