Fix Wayland key repeat frequency#1055
Merged
Merged
Conversation
Owner
|
kitty's copy of glfw has diverged from upstream, so if you want to send it upstream, it would probably be a different patch. |
Contributor
Author
|
I noticed that the code has diverged, will you be syncing with upstream again at some point in the near future? Because If you do not, I don't really care to go and test with upstream glfw I suppose. And if you will sync I may just go about fixing it then I suppose. |
Owner
|
No the divergence is permanent for many reasons, principally glfw/glfw#1140 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Wayland protocol specification uses a Hz value in the key repeat rate field. The code however uses this value as a millisecond interval. This pull request makes the code calculate the interval from the Hz value.
This should probably be upstreamed to glfw but I'm not entirely sure how to go about that since the code seems to have seen quite a few changes there (but looks like it still does the wrong thing here).