Adds an exec() method for any object with a ready_pods() method #605
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #605 +/- ##
==========================================
- Coverage 94.61% 93.94% -0.68%
==========================================
Files 29 30 +1
Lines 3141 4309 +1168
==========================================
+ Hits 2972 4048 +1076
- Misses 169 261 +92 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #600
Added a generic
exec()method to theAPIObjectbase class. It checks for aready_pods()method, if it doesn't exist it raises aNotImplementedError. If it does exist it gets the first Pod fromready_pods()and then callsexec()on thatPodpassing the args/kwargs along.Also added a
ready_pods()method toDeploymentwhich applied a ready filter to the existingpods()method.