Add Vidora to HLS Tools#90
Open
romainGouraud wants to merge 1 commit into
Open
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideAdds a new HLS tool entry (Vidora Chrome extension) to the README, positioned alphabetically in the HLS Tools list, with a concise description and Chrome Web Store link. Flow diagram for adding Vidora to HLS Tools listflowchart TD
HLS_Tools_List[HLS Tools section in README]
Vidora_Entry[Add Vidora entry
- Chrome Web Store URL
- AES-128 HLS, external audio]
Updated_README[Updated README with Vidora between
HLS_Streaming and Tide]
HLS_Tools_List --> Vidora_Entry --> Updated_README
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've found 1 issue, and left some high level feedback:
- The README explicitly asks contributors to update
CONTENTS.JSONinstead of editing it directly, so this change should be moved there and the README regenerated to stay consistent with the project’s workflow. - Consider tightening the Vidora description to match the brevity and style of nearby entries (e.g., remove marketing-style phrases like “out of the box” and focus on the core technical capabilities).
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The README explicitly asks contributors to update `CONTENTS.JSON` instead of editing it directly, so this change should be moved there and the README regenerated to stay consistent with the project’s workflow.
- Consider tightening the Vidora description to match the brevity and style of nearby entries (e.g., remove marketing-style phrases like “out of the box” and focus on the core technical capabilities).
## Individual Comments
### Comment 1
<location path="README.md" line_range="747" />
<code_context>
+* [Vidora](https://chromewebstore.google.com/detail/vidora-pro-video-download/pjnnoldljndmfifpnfmbpbehklaaboje) - Chrome MV3 extension that downloads HLS streams including AES-128 encrypted ones, with external audio rendition support (Apple-style HLS). Vimeo and Bunny CDN out of the box, all processing local.
</code_context>
<issue_to_address>
**nitpick (typo):** Small grammatical tweak: add a verb in "all processing local" (e.g., "all processing is local").
This will make the sentence grammatically complete and easier to read.
```suggestion
* [Vidora](https://chromewebstore.google.com/detail/vidora-pro-video-download/pjnnoldljndmfifpnfmbpbehklaaboje) - Chrome MV3 extension that downloads HLS streams including AES-128 encrypted ones, with external audio rendition support (Apple-style HLS). Vimeo and Bunny CDN out of the box, all processing is local.
```
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
| * [soldiermoth/hlsq](https://github.com/soldiermoth/hlsq) - A CLI for adding some color to your HLS manifests along with some basic filtering | ||
| * [tjenkinson/mock-hls-server](https://github.com/tjenkinson/mock-hls-server) - Fake a live/event HLS stream from a VOD one. Useful for testing. - tjenkinson/mock-hls-server | ||
| * [tozastation/HLS-Streaming](https://github.com/tozastation/HLS-Streaming) - HLSを使ってみたです．. | ||
| * [Vidora](https://chromewebstore.google.com/detail/vidora-pro-video-download/pjnnoldljndmfifpnfmbpbehklaaboje) - Chrome MV3 extension that downloads HLS streams including AES-128 encrypted ones, with external audio rendition support (Apple-style HLS). Vimeo and Bunny CDN out of the box, all processing local. |
There was a problem hiding this comment.
nitpick (typo): Small grammatical tweak: add a verb in "all processing local" (e.g., "all processing is local").
This will make the sentence grammatically complete and easier to read.
Suggested change
| * [Vidora](https://chromewebstore.google.com/detail/vidora-pro-video-download/pjnnoldljndmfifpnfmbpbehklaaboje) - Chrome MV3 extension that downloads HLS streams including AES-128 encrypted ones, with external audio rendition support (Apple-style HLS). Vimeo and Bunny CDN out of the box, all processing local. | |
| * [Vidora](https://chromewebstore.google.com/detail/vidora-pro-video-download/pjnnoldljndmfifpnfmbpbehklaaboje) - Chrome MV3 extension that downloads HLS streams including AES-128 encrypted ones, with external audio rendition support (Apple-style HLS). Vimeo and Bunny CDN out of the box, all processing is local. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Vidora - HLS/AES-128/DASH video downloader Chrome extension
Adds Vidora to the HLS Tools subsection, alphabetically between
tozastation/HLS-Streamingandyuhuili-lab/Tide.What it is: a Chrome MV3 extension that downloads video streams directly from the browser. The differentiator vs the existing entries (
puemos/hls-downloader-chrome-extension,denex/hls-downloader,egg-bread/hls-to-mp4, etc.):Details:
The existing
puemos/hls-downloader-chrome-extensionentry covers basic HLS in Chrome but not AES-128 decryption or external audio renditions. Happy to refine the description or move to a different section if you prefer.Summary by Sourcery
Documentation: