Conversation
- When using or , requires a root certificate trust store for to validate server certificates. - Because was omitted, the DNS-over-TLS client had zero trusted CAs, causing all TLS handshakes to instantly fail. - These TLS failures were bubbling up as confusing or errors depending on the nameserver permutation. - Added the feature to ensure TLS connections to nameservers (like 1.1.1.1 and 8.8.8.8) succeed.
- Remove from the trigger in . - When a tag (e.g. ) is pushed to , both the workflow (triggered by the tag) and the workflow (triggered by the push to ) were running simultaneously, causing duplicate and wasteful runner execution. - Now, standard tests and linting will only automatically run on the branch directly, or when Pull Requests are opened against .
Owner
Author
|
Cool beans! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
webpki-rootsfeature tohickory-resolver. When using--tlsor--https,hickory-resolverrequires a root certificate trust store forrustlsto validate server certificates. This prevents connections from being incorrectly dropped asconnection refused.masterpushes to prevent tests from firing twice when tagging releases.0.5.3.