Fix definition module name & location #1495
Conversation
|
I haven't a clue how exactly this caused the tests to fail. I'll have a look later today |
|
New solver error messages now include the type definition location when they didn't have that info before. |
I see - is the best approach to just change the test, then? |
|
For the |
|
I recall why I didn't implement this before. |
aatxe
left a comment
There was a problem hiding this comment.
This needs to be flagged (just with a normal fflag, we're sunsetting the DFInt), but otherwise looks fine.
| const IterableConstraint& c, | ||
| NotNull<const Constraint> constraint | ||
| ) | ||
| bool ConstraintSolver::tryDispatchIterableFunction(TypeId nextTy, TypeId tableTy, const IterableConstraint& c, NotNull<const Constraint> constraint) |
There was a problem hiding this comment.
Is this formatting change coming from clang-format?
There was a problem hiding this comment.
yes, can be reverted if you like
| } | ||
| } | ||
| else if (expr->is<AstExprConstantBool>() || expr->is<AstExprConstantString>() || expr->is<AstExprConstantNumber>() || expr->is<AstExprConstantNil>()) | ||
| else if (expr->is<AstExprConstantBool>() || expr->is<AstExprConstantString>() || expr->is<AstExprConstantNumber>() || |
There was a problem hiding this comment.
Is this formatting change coming from clang-format?
There was a problem hiding this comment.
yes, can be reverted if you like
flag gated |
bb825ad to
d9865a5
Compare
aatxe
left a comment
There was a problem hiding this comment.
Looks good to me, cheers!
) Follow up to #1495: a small fixup for the defining module and location to get set even when cloning was required.
Closes #1441
Brings behavior to parity with the old solver by filling in definitionLocation and definitionModuleName for Luau-consuming programs/libraries to use.