Add formFactor property to UADataValues
#5
Conversation
|
Thanks for this! |
|
This is released in 0.4.1. The type as per https://wicg.github.io/ua-client-hints/#dom-uadatavalues-formfactor is actually just a string not a string[] just in case you notice that difference when you upgrade. Thanks for pointing out I was missing this property! |
|
I was referring to it at first, but judging by this commit (that's just pushed yesterday): WICG/ua-client-hints@65215d8 I just thought it might eventually get changed into a |
|
Ah thanks for pointing me to that. I'll keep an eye out for any changes and am happy to update the types once the Ua Data Spec / Chrome implementation changes :) |
|
I've left a comment WICG/ua-client-hints#343 (comment) trying to get clarification on this |
|
@faisalman as an update the spec has been corrected so I've changed it back to an array and released 0.4.2. Apologies for that back and forth. Thanks once again! |
|
Thanks to you! Happy to help 👍 |
Hi, thanks for the types! I'm using it and just made a small update to also include the recently added
formFactordata: https://wicg.github.io/ua-client-hints/#sec-ch-ua-form-factor