Bump to wasmtime one oh oh oh ! #139
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: pinkforest <36498018+pinkforest@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🥳 https://bytecodealliance.org/articles/wasmtime-1-0-fast-safe-and-production-ready
Anyways - please merge #138 into v0.10 before and release point-release there
And then this can be for v0.11 release but ideally wait until wasmtime v1.0.1 has appeared so it contains the fix for the above as well
0.40 wasmtime ended up having patched 0.25 cap-primitives (and two other crates) via crates.io patching
1.0 wasmtime will have proper release 1.0.1 that contains the fixes discussed in #138
I could always patch the branches on 1.0 too but I'll wait and see what happens re: point releases
Let me know when you are back and we can talk this through.