Fix integration tests on macOS#754
Merged
taik0 merged 1 commit intoAug 19, 2025
Merged
Conversation
586ea5d to
0abd3d1
Compare
kpacha
approved these changes
Apr 29, 2025
Member
|
@thiagosalles can you please sign your commits with |
0abd3d1 to
e8c3981
Compare
Contributor
Author
Hello, @kpacha. OK, done! |
Signed-off-by: Thiago Salles <tsmlima@gmail.com>
e8c3981 to
c54913d
Compare
taik0
approved these changes
Aug 19, 2025
taik0
added a commit
that referenced
this pull request
Aug 19, 2025
Signed-off-by: Daniel Ortiz <dortiz@krakend.io>
|
This pull request was marked as resolved a long time ago and now has been automatically locked as there has not been any recent activity after it. You can still open a new issue and reference this link. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix integration tests by binding the listener to localhost, just like the client
The integration tests were failing because the server listener was configured with
net.Listen("tcp", ":8080"), without specifying a hostname, which binds to all network interfaces (including IPv6). Meanwhile, the client connection usednet.Dial("tcp", "localhost:8080"), which resolved to IPv4 (127.0.0.1) on my machine.The discrepancy between the listener accepting both IPv4 and IPv6 and the client specifically using IPv4 may have caused the
X-Forwarded-Forheader to be populated with the client’s IP (127.0.0.1) instead of being empty, as the tests expected.Changing the listener to
net.Listen("tcp", "localhost:8080")ensures the server binds to the same interface as the client, aligning with the test expectations and fixing the failures.Evidence
After the modification, the integration tests pass successfully:
Fixes #753