PoC: Add support for system xxHash #1492
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
What do you think about this proposal? |
c680d8f to
d1ee9eb
Compare
In general, packaging systems such as .deb want to use packaged dependencies instead of bundled dependencies. LZ4 bundles xxHash but system xxHash is preferred. Changes: * Move `lib/xxhash.[ch]` to `lib/xxhash/xxhash.[ch]` and use `#include "xxhash/xxhash.h"` instead of `#include "xxhash.h"` to distinct bundled xxHash and system xxHash * Add `LZ4_USE_SYSTEM_XXHASH` macro to use system xxHash * Use `#include "..."` instead of `-I...` to use our header files * Only CMake build supports system xxHash by `-DLZ4_USE_SYSTEM_XXHASH` for now
d1ee9eb to
b9154b8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In general, packaging systems such as .deb want to use packaged dependencies instead of bundled dependencies. LZ4 bundles xxHash but system xxHash is preferred.
Changes:
lib/xxhash.[ch]tolib/xxhash/xxhash.[ch]and use#include "xxhash/xxhash.h"instead of#include "xxhash.h"to distinct bundled xxHash and system xxHashLZ4_USE_SYSTEM_XXHASHmacro to use system xxHash#include "..."instead of-I...to use our header files-DLZ4_USE_SYSTEM_XXHASHfor now