Update dependencies that broke CI#102
Merged
malishav merged 2 commits intoSep 30, 2023
Merged
Conversation
Contributes-To: lake-rs#98
Member
Author
|
I've updated the PR to also work around a semver incompatible update to the coap crate in Covertness/coap-rs#87, which hit crates.io about 4h ago. Keeping both in one PR as none of them alone has a chance of clearing CI. |
The 0.12.2 version briefly caused build issues[1], and while the problematic release is yanked, this is still a good update. [1]: Covertness/coap-rs#87
bed7c33 to
25964b6
Compare
Member
Author
|
One more fix: covertness fixed the coap-rs issue, so to avoid referencing a now yanked version, the forcepushed version now uses the newest CoAP release right away. |
Member
|
Let me know if this is ready for merge? |
Member
Author
|
Ready if CI says so.
|
Member
|
Thanks for providing this PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With thvdveld/cc2538-hal#2 closed, cc2538-hal now has a published 0.2.0 that contains the crypto code we previously had a git branch dependency on.
This should fix the build failures that started when the PR was closed and the branch removed.
The -pac crate is updated in lockstep with -hal's dependency to avoid duplicates; the
.take().expect(...)idiom is exchanged with an unsafe.steal()following the examples of cc2538-hal.Contributes-To: #98
CC'ing @thvdveld who is probably the best person to review this.