Preparations for crates.io publishing#146
Merged
geonnave merged 5 commits intoNov 21, 2023
Merged
Conversation
7af45f1 to
d04ea36
Compare
geonnave
reviewed
Nov 20, 2023
| [package] | ||
| name = "edhoc-consts" | ||
| version = "0.1.0" | ||
| version.workspace = true |
Collaborator
There was a problem hiding this comment.
Ahh! I was wondering if there was an easy way to keep all version numbers in sync. Great!
Closed
This makes versions easier to maintain, especially when assigning numbers to the dependencies as well in preparation for crates.io.
This addresses a warning cargo would otherwise issue at upload, and is generally good for discoverability.
2921046 to
2041dd5
Compare
chrysn
commented
Nov 20, 2023
geonnave
reviewed
Nov 21, 2023
| @@ -1,12 +1,13 @@ | |||
| [package] | |||
| name = "edhoc-crypto-rustcrypto" | |||
Collaborator
There was a problem hiding this comment.
@chrysn feel free to add yourself as author of this and the crypto-trait crates.
Member
Author
There was a problem hiding this comment.
Done (wasn't sure we're doing authors = , cargo doesn't set it by default any more); crypto-trait has been taken up into -consts.
As per [152] and the existing LICENSE.md file, the BSD license applied to this project uses the SPDX identifier BSD-3-Clause. [152]: lake-rs#152 (comment)
Collaborator
|
This looks good to me. Anything missing? |
Member
Author
|
I think this is ready. The open question of when to publish at crates.io (and on which name -- I've privately contacted the author of the edhoc crate whether he still plans to maintain that) can be answered well after this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This supersedes #98. In this new approach, all version related stuff is pulled together in the workspace, necessitating changes in only one file (rather than every Cargo.toml) during version bumps.
This is based on #144; as GitHub still can't do staggered PRs, please start reviewing starting at "chore: pull version numbers...", and don't merge before #144.