-
-
Notifications
You must be signed in to change notification settings - Fork 38
Add ToString filter
#188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ToString filter
#188
Conversation
Signed-off-by: Markus Lussi <info@m-lussi.de>
gsteel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @mlussi90
The ToString filter will need to be added to the default set of filters in FilterPluginManager - additionally, the v2 docs will need updating 👍
…, add condition for stringable, fix psalm return type definition Signed-off-by: Markus Lussi <info@m-lussi.de>
|
i tried to implement all your requested changes, can you take a look? |
gsteel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @mlussi90 - Nearly there…
You can fix coding style problems by running vendor/bin/phpcbf and psalm issues with the tests can be silenced with vendor/bin/psalm --set-baseline=psalm-baseline.xml
Signed-off-by: Markus Lussi <info@m-lussi.de>
Signed-off-by: Markus Lussi <info@m-lussi.de>
gsteel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @mlussi90
In order to get CI green for Psalm, you'll need to refresh the baseline - this sort of thing can happen, particularly on Mac, so it's not your fault!
Try running vendor/bin/psalm --update-baseline --no-cache --threads=1 and verify there are no more problems with vendor/bin/psalm --no-cache --threads=1, then commit the altered baseline.
The BC check failure can be ignored - it's complaining about the altered default value for plugin manager factories.
Signed-off-by: Markus Lussi <info@m-lussi.de>
|
@gsteel thank you very much for your help, the checks are looking better now i think |
gsteel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @mlussi90
I'll merge and release shortly, once I've got the docs organised 👍
Signed-off-by: George Steel <george@net-glue.co.uk>
ToString filter
Description
#98 Adding a ToString Filter according to the requirements from @vaclavvanik