Validate OAuth registration client names#177
Merged
pushpak1300 merged 5 commits intoMar 19, 2026
Merged
Conversation
Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-opencode) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-opencode) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-opencode) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
namefallback whenclient_nameis absentclient_nameprecedenceValidation
vendor/bin/pest tests/Unit/Server/RegistrarTest.php --filter='requires an oauth client name|falls back to the legacy name field|prefers client_name over name'vendor/bin/pest tests/Unit/Server/RegistrarTest.phpvendor/bin/pint --test src/Server/Http/Controllers/OAuthRegisterController.php tests/Unit/Server/RegistrarTest.phpNotes
composer test:lintstill fails locally because of a pre-existingsrc/Facades/Mcp.phpPint issue unrelated to this diff.composer test:unitstill needs a coverage driver in this environment, so the focused Pest runs above were used for local verification.