Extract protocol versions to shared enum for client reuse#215
Merged
Conversation
joetannenbaum
approved these changes
May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the list of MCP protocol versions the package speaks is hardcoded inside
Server.php:The upcoming MCP client (per the shipping plan) needs the same information — both sides need to agree on what versions exist, and the client needs to know which one is "latest" to send during the
initializehandshake. Duplicating the list in two places will inevitably drift.This PR moves the list into a shared enum, so server and client read from one place:
Servers that don't override the property continue to advertise the full supported list — no behavior change. If you want to pin a server to a single version, the override path stays the same as today: