Remove MCP client tool-list caching layer#235
Merged
Conversation
095027c to
2a9a56f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The MCP client shipped a built-in tool-list cache. It fought the package's thin, app-owns-storage philosophy and added a per-user cache-scoping footgun. It also kept getting more awkward as the OAuth work landed: the API for configuring it grew weirder the more cases it tried to cover. In practice most apps don't need to cache the tools list at all, and the ones that do already have a cache they trust. So this hands caching back to the application. The package just gives you a correct tools list, and you store it however you like.
Before, you configured caching through the package:
After, registration is just a name and a factory, and the tools list is a plain value you can cache directly: