Skip to content
This repository was archived by the owner on May 13, 2026. It is now read-only.

Enable exception proc_map, working with dataclasses, etc.#372

Merged
joyeshmishra merged 4 commits into
lava-nc:mainfrom
GaboFGuerra:optimization_features
Sep 27, 2022
Merged

Enable exception proc_map, working with dataclasses, etc.#372
joyeshmishra merged 4 commits into
lava-nc:mainfrom
GaboFGuerra:optimization_features

Conversation

@GaboFGuerra

Copy link
Copy Markdown
Contributor

Signed-off-by: GaboFGuerra gabriel.fonseca.guerra@intel.com

Issue Number:

Objective of pull request:

Pull request checklist

Your PR fulfills the following requirements:

  • Issue created that explains the change and why it's needed
  • Tests are part of the PR (for bug fixes / features)
  • Docs reviewed and added / updated if needed (for bug fixes / features)
  • PR conforms to Coding Conventions
  • PR applys BSD 3-clause or LGPL2.1+ Licenses to all code files
  • Lint (flakeheaven lint src/lava tests/) and (bandit -r src/lava/.) pass locally
  • Build tests (pytest) passes locally

Pull request type

Please check your PR type:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation changes
  • Other (please describe):

What is the current behavior?

What is the new behavior?

Does this introduce a breaking change?

  • Yes
  • No

Supplemental information

@mgkwill mgkwill marked this pull request as ready for review September 27, 2022 17:53
@joyeshmishra joyeshmishra self-requested a review September 27, 2022 19:26

@bamsumit bamsumit left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two issues to discuss later

@joyeshmishra joyeshmishra merged commit 15c2574 into lava-nc:main Sep 27, 2022
@joyeshmishra joyeshmishra deleted the optimization_features branch September 27, 2022 20:08
mgkwill added a commit that referenced this pull request Sep 28, 2022
* Enable exception proc_map, working with dataclasses, etc.

Signed-off-by: GaboFGuerra <gabriel.fonseca.guerra@intel.com>

* Fix lint issue and check if run_cfg has exception model map

Signed-off-by: GaboFGuerra <gabriel.fonseca.guerra@intel.com>
Co-authored-by: Marcus G K Williams <168222+mgkwill@users.noreply.github.com>
Co-authored-by: Joyesh Mishra <joyesh.mishra@intel.com>
monkin77 pushed a commit to monkin77/thesis-lava that referenced this pull request Jul 12, 2024
* Enable exception proc_map, working with dataclasses, etc.

Signed-off-by: GaboFGuerra <gabriel.fonseca.guerra@intel.com>

* Fix lint issue and check if run_cfg has exception model map

Signed-off-by: GaboFGuerra <gabriel.fonseca.guerra@intel.com>
Co-authored-by: Marcus G K Williams <168222+mgkwill@users.noreply.github.com>
Co-authored-by: Joyesh Mishra <joyesh.mishra@intel.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants