Skip to content
This repository was archived by the owner on May 13, 2026. It is now read-only.

Public processes for optimization solver#374

Merged
phstratmann merged 2 commits into
lava-nc:mainfrom
phstratmann:main
Sep 26, 2022
Merged

Public processes for optimization solver#374
phstratmann merged 2 commits into
lava-nc:mainfrom
phstratmann:main

Conversation

@phstratmann

Copy link
Copy Markdown
Contributor

Objective of pull request:
Provide all public processes for GG's optimization solver.
Note: All process.py and models.py are from GG's private repo. I only added a new models.py for Spiker, as well as the corresponding unit test.

Pull request checklist

Your PR fulfills the following requirements:

  • Issue created that explains the change and why it's needed
  • Tests are part of the PR (for bug fixes / features)
  • Docs reviewed and added / updated if needed (for bug fixes / features)
  • PR conforms to Coding Conventions
  • PR applys BSD 3-clause or LGPL2.1+ Licenses to all code files
  • Lint (flakeheaven lint src/lava tests/) and (bandit -r src/lava/.) pass locally
  • Build tests (pytest) passes locally

Pull request type

Please check your PR type:

  • Feature

@phstratmann phstratmann added the 1-feature New feature request label Sep 26, 2022
@phstratmann phstratmann self-assigned this Sep 26, 2022

@GaboFGuerra GaboFGuerra left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Philipp, that's exactly it ;)

@bamsumit bamsumit left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good Phillip. Some comments on docstring styling.

Comment thread src/lava/proc/cost_integrator/process.py Outdated
Comment thread src/lava/proc/cost_integrator/process.py Outdated
@phstratmann phstratmann merged commit 49e2115 into lava-nc:main Sep 26, 2022
monkin77 pushed a commit to monkin77/thesis-lava that referenced this pull request Jul 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

1-feature New feature request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants