Don't manipulate the Turbo Frame itself#19
Merged
Conversation
38dc555 to
ccfba4d
Compare
ccfba4d to
8b57ecb
Compare
To prevent unwanted layout altering
8b57ecb to
b98f227
Compare
This was referenced Jun 10, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #18
This PR introduces a new approach to highlighting Turbo Frames.
Instead of modifying the Turbo Frame itself, we add an additional div for each Turbo Frame and apply our styling to this div.
The added div will have a
position: absolute;property and be placed on top of the Turbo Frames.This change results in slightly decreased performance because more elements are appended to the DOM. However, it minimizes the risk of unwanted layout changes, which I believe justifies the performance impact.
If users with hundreds of Turbo Frames on a page notice a performance issue, we have solutions such as the Turbo Frame blacklist or page-specific option changes.