Fix outdir quoting issue for tectonic compiler #2436
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For the tectonic compiler: if the path to the file contains spaces, outdir is not quoted properly and hence the build command does not work. This commit fixes that by escaping the path with `fnameescape()`.
Owner
|
Thanks! I'll accept this, except I don't want the modern method style. Simply because it breaks from the style used throughout in the VimTeX code - I do generally agree it is a nice style! |
lervag
reviewed
Jul 13, 2022
Owner
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the tectonic compiler: if the path to the file contains spaces, outdir is not quoted properly and hence the build command does not work. This commit fixes that by escaping the path with
fnameescape().Minimal example of the fixed issue:
main.texto create a valid document.let g:vimtex_compiler_method='tectonic':VimtexCompileOutputshows that'spaces'in the path is treated as a separate argument, though it should not be.