Complete syntax support for SageTeX #2929
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lervag
reviewed
Apr 20, 2024
Owner
lervag
left a comment
There was a problem hiding this comment.
Thanks! I believe we should go forward with this, but I have a few comments.
Contributor
Author
|
Thanks for the feedback! I'm new to Vimscript, so I apologize for the poor code. I made the changes you requested. Let me know what you think. |
Owner
No need to apologize! I'm very happy to see the contribution and I'm glad to see you not being too annoyed by my slightly pedantic review comments ;) As you see, I had one more follow-up comment - I propose to not add the |
lervag
added a commit
that referenced
this pull request
Apr 20, 2024
lervag
added a commit
that referenced
this pull request
Apr 20, 2024
lervag
added a commit
that referenced
this pull request
Apr 21, 2024
Owner
|
Thanks; I've merged this now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I read through the SageTeX documentation to make sure no commands were missed.
$2+2=\sage{2+2}$is a valid use of\sage(see SageTeX documentation). The contents of its argument should not be considered math, rather Python code.\sageand\sagestrcommands can be used in a mathzone and not in a mathzone, since their purpose is to just convert their Sage input into LaTeX output. Added support for this.