Skip to content

fix: unscrollable and click issues in Flutter 1.5+ #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gzhongcheng wants to merge 1 commit into from
Closed

fix: unscrollable and click issues in Flutter 1.5+ #52

gzhongcheng wants to merge 1 commit into from

Conversation

@gzhongcheng
Copy link

@gzhongcheng gzhongcheng commented May 14, 2019

fix: unscrollable and click issues in Flutter 1.5+

@gzhongcheng
fix: unscrollable and click issues in Flutter 1.5+
652632a 
fix: unscrollable and click issues in Flutter 1.5+
@akashmi akashmi mentioned this pull request May 15, 2019
Closed
@tomaszpolanski
Copy link

tomaszpolanski commented May 16, 2019

The BoxHitTestResult was introduced recently:

Revision: 1621baafc7c6598b81a48502144fcee2d8b55b2b
Author: Michael Goderbauer <goderbauer@google.com>
Date: 09/05/2019 10:00:01
Message:
Introduce separate HitTestResults for Box and Sliver (#31894)

That is merging it now would break for people who use beta and stable branches of Flutter

@cmcgill1988
Copy link

cmcgill1988 commented May 22, 2019

Given that the new stable version according to flutter is 1.5.4-hotfix.2 in the stable branch, would this fix still cause the issue you mentioned @tomaszpolanski ?

Theunodb
Theunodb reviewed May 23, 2019
View reviewed changes
Copy link

@Theunodb Theunodb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This resolves the issue

@letsar
Copy link
Owner

letsar commented May 25, 2019

Already fixed in #47

@letsar letsar closed this May 25, 2019
@gzhongcheng gzhongcheng deleted the patch-1 branch May 27, 2019 02:38
@hannahgrinton hannahgrinton mentioned this pull request Feb 25, 2021
Closed
@ZTMIDGO ZTMIDGO mentioned this pull request Jul 18, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@Theunodb Theunodb Theunodb left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@gzhongcheng @tomaszpolanski @cmcgill1988 @letsar @Theunodb