Skip to content

Makefile: save QEMU PID to file#5779

Merged
eriknordmark merged 1 commit into
lf-edge:masterfrom
shjala:qemu-save-pidfile
Apr 10, 2026
Merged

Makefile: save QEMU PID to file#5779
eriknordmark merged 1 commit into
lf-edge:masterfrom
shjala:qemu-save-pidfile

Conversation

@shjala
Copy link
Copy Markdown
Member

@shjala shjala commented Apr 9, 2026 •
edited
Loading

Description

Add QEMU_PID_FILE variable and pass -pidfile to QEMU_OPTS_COMMON to write the QEMU process ID to disk. This allows scripts to reliably locate and kill the running QEMU instance when building and running EVE in a scripted environment.

Add qemu.pid to .gitignore.

PR dependencies

None.

How to test and validate this PR

N/A

Changelog notes

None

PR Backports

None.

Checklist

  • I've provided a proper description
  • I've added the proper documentation
  • I've tested my PR on amd64 device
  • I've tested my PR on arm64 device
  • I've written the test verification instructions
  • I've set the proper labels to this PR

For backport PRs (remove it if it's not a backport):

  • I've added a reference link to the original PR
  • PR's title follows the template

And the last but not least:

  • I've checked the boxes above, or I've provided a good reason why I didn't
    check them.

Please, check the boxes above after submitting the PR in interactive mode.

@shjala shjala requested a review from eriknordmark as a code owner April 9, 2026 12:32
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 9, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 29.87%. Comparing base (2281599) to head (62905b3).
⚠️ Report is 464 commits behind head on master.

Additional details and impacted files 
@@             Coverage Diff             @@
##           master    #5779       +/-   ##
===========================================
+ Coverage   19.52%   29.87%   +10.34%     
===========================================
  Files          19       18        -1     
  Lines        3021     2417      -604     
===========================================
+ Hits          590      722      +132     
+ Misses       2310     1549      -761     
- Partials      121      146       +25

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@shjala
Makefile: save QEMU PID to file
62905b3 
Add QEMU_PID_FILE variable and pass -pidfile to QEMU_OPTS_COMMON to
write the QEMU process ID to disk.

Add qemu.pid to .gitignore.

Signed-off-by: Shahriyar Jalayeri <shahriyar@posteo.de>
@shjala shjala force-pushed the qemu-save-pidfile branch from e7796c3 to 62905b3 Compare April 9, 2026 14:35
@shjala
Copy link
Copy Markdown
Member Author

shjala commented Apr 9, 2026

Rebased on master, still Docker hashes consistency issue?

@rucoder
Copy link
Copy Markdown
Contributor

rucoder commented Apr 10, 2026

Rebased on master, still Docker hashes consistency issue?

@shjala yes, I hope we fix it today. Please explain in PR why we need PID file. not clear to me

@christoph-zededa
Copy link
Copy Markdown
Contributor

christoph-zededa commented Apr 10, 2026

Rebased on master, still Docker hashes consistency issue?

@shjala yes, I hope we fix it today. Please explain in PR why we need PID file. not clear to me

I find it helpful; then I can get the pid of qemu from this file instead of ps auxww | grep qemu for my qmp shell script.

rene
rene approved these changes Apr 10, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@rene rene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eriknordmark
Copy link
Copy Markdown
Contributor

eriknordmark commented Apr 10, 2026

FWIW 2/4 eden failures in FAIL: TestEdenScripts/hw_inventory and 2/4 in FAIL: TestEdenScripts/log_test

@eriknordmark eriknordmark merged commit ac34a38 into lf-edge:master Apr 10, 2026
43 of 50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rene rene rene approved these changes

@eriknordmark eriknordmark Awaiting requested review from eriknordmark eriknordmark is a code owner

+1 more reviewer

@christoph-zededa christoph-zededa christoph-zededa approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@shjala @rucoder @christoph-zededa @eriknordmark @rene