dpcmanager: increase PNAC DHCP reacquire timeout to avoid flaky tests#5860
Merged
Conversation
The first-retry Eventually checks in the three PNAC DHCP reacquire tests used a 5s timeout for a reacquire that fires after ~2s backoff. This left only ~1s of margin because the periodic dpcTestTimer (NetworkTestInterval=2s) fires at roughly the same time and blocks the main select loop for another ~2s while running testConnectivityToController. Under CI load (goroutine pressure from preceding tests that do not clean up initTest state), this margin was insufficient, causing TestPNACDHCPReacquireCancelledByNewDPC to time out. Increase the timeout from 5s to 10s across all three affected tests and add an explanatory comment in the failing test. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Renê de Souza Pinto <rene@renesp.com.br>
milan-zededa
approved these changes
Apr 24, 2026
Contributor
milan-zededa
left a comment
There was a problem hiding this comment.
Thanks, and no need to backport, SCEP support is not in 16.0
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #5860 +/- ##
==========================================
- Coverage 19.52% 17.03% -2.50%
==========================================
Files 19 477 +458
Lines 3021 85762 +82741
==========================================
+ Hits 590 14609 +14019
- Misses 2310 69642 +67332
- Partials 121 1511 +1390 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR tries to fix several Go-Tests fails during timeout of dpcmanager_test, like the following:
https://github.com/lf-edge/eve/actions/runs/24859644144/job/72781692997?pr=5854#step:7:3214
https://github.com/lf-edge/eve/actions/runs/24859644144/job/72781692997?pr=5854#step:7:3213
The first-retry Eventually checks in the three PNAC DHCP reacquire tests used a 5s timeout for a reacquire that fires after ~2s backoff. This left only ~1s of margin because the periodic dpcTestTimer (NetworkTestInterval=2s) fires at roughly the same time and blocks the main select loop for another ~2s while running testConnectivityToController. Under CI load (goroutine pressure from preceding tests that do not clean up initTest state), this margin was insufficient, causing TestPNACDHCPReacquireCancelledByNewDPC to time out.
Increase the timeout from 5s to 10s across all three affected tests and add an explanatory comment in the failing test.
🤖 Generated with Claude Code
How to test and validate this PR
Run go-tests from our CI/CD workflows.
Changelog notes
None. This is related to our CI/CD infra.
PR Backports
No backports. See: #5860 (review)
Checklist
check them.