Makefile: Signing-Off setting server to prod commit#5883
Merged
Conversation
Every time a release is created through the make release target, a commit that sets the default server to production URL is automatically pushed. However, this commit is never Signed-off, which goes against our policy. This commit adds the -s to git command in order to enforce the commit to be Signed-off by the maintainer that is creating the new release. Signed-off-by: Renê de Souza Pinto <rene@renesp.com.br>
christoph-zededa
approved these changes
Apr 30, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #5883 +/- ##
==========================================
- Coverage 19.52% 17.11% -2.42%
==========================================
Files 19 474 +455
Lines 3021 85660 +82639
==========================================
+ Hits 590 14657 +14067
- Misses 2310 69484 +67174
- Partials 121 1519 +1398 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Every time a release is created through the
make releasetarget, a commit that sets the default server to production URL is automatically pushed. However, this commit is never Signed-off, which goes against our policy. This commit adds the -s to git command in order to enforce the commit to be Signed-off by the maintainer that is creating the new release.How to test and validate this PR
Create a new release and check the last commit:
Changelog notes
None.
PR Backports
We can follow this approach moving forward, I don't think it's something worth of backport.
Checklist
check them.