Typo fix in tess_search.ipynb #29
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think the idea of this splitting trick is to plot successive chunks of the light curve with plt.plot so that the lines are not linearly joined. For this to work, I think the time array here needs to be "time_masked", not "time".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Lionel,
Thanks for this lovely tool!
This PR addresses what I think is a typo in the "tess_search" notebook from the docs: I think the idea of the relevant splitting trick is to plot successive chunks of the light curve with plt.plot so that the lines are not linearly joined. For this to work, I think the time array here needs to be "time_masked", not "time".
Thanks again!
Luke