Remove a bunch of rubocop todos that require no restructuring #916
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rename one duplicated example description so the cop can be removed from .rubocop_todo.yml.
Drop the redundant final return while keeping the same string result for pseudo licenses.
Replace frozen string literal .dup with unary plus in two specs and drop the cop exclusion from .rubocop_todo.yml.
Replace be == with eq(...) and remove the RSpec/Eq exclusion from .rubocop_todo.yml.
Avoid stubbing the subject by using a small matcher subclass in package_matcher_spec and by relying on real LicenseFile behavior in project_file_spec; remove the cop exclusion from .rubocop_todo.yml.
Cop has no offenses; todo referenced non-existent spec paths, so drop the section from .rubocop_todo.yml.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One per commit, see commits.