Prepare cloud eval #1426
Merged
Prepare cloud eval #1426
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… will be a base class for cloud evals and local evals
and a sealed class ClientEval with common properties and methods between CloudEval and LocalEval
402606d to
04ee3d1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ClientEvalclass toLocalEvalso that we can add a new sealed classClientEvalthat will have common properties betweenCloudEvalandLocalEval. The website client also does something similar https://github.com/lichess-org/lila/blob/c51ca345338892a742d676bcda87de9a1e1e6c5e/ui/%40types/lichess/tree.d.ts#L20.ClientEvaland the classCloudEval