Skip to content

Fix broadcast clocks when using flip board #1428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 12, 2025
Merged

Fix broadcast clocks when using flip board #1428

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
707d508
Add a key to the broadcast player widget so that when the board is
julien4215 Feb 12, 2025
bf31792
Add a comment to explain why a key is needed in broadcast player widget
julien4215 Feb 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions lib/src/view/broadcast/broadcast_game_screen.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,12 +173,16 @@ class _Body extends ConsumerWidget {
(context, boardSize, borderRadius) =>
_BroadcastBoard(roundId, gameId, boardSize, borderRadius),
boardHeader: _PlayerWidget(
// We need to use a key to preserve the state of the clock when board is flipped
key: const ValueKey('top'),
tournamentId: tournamentId,
roundId: roundId,
gameId: gameId,
widgetPosition: _PlayerWidgetPosition.top,
),
boardFooter: _PlayerWidget(
// We need to use a key to preserve the state of the clock when board is flipped
key: const ValueKey('bottom'),
tournamentId: tournamentId,
roundId: roundId,
gameId: gameId,
Expand Down Expand Up @@ -381,6 +385,7 @@ enum _PlayerWidgetPosition { bottom, top }

class _PlayerWidget extends ConsumerWidget {
const _PlayerWidget({
required super.key,
required this.tournamentId,
required this.roundId,
required this.gameId,
Expand Down