Skip to content

Refactor engine evaluation #1500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 29 commits into from
Mar 3, 2025
Merged

Refactor engine evaluation #1500

merged 29 commits into from
Mar 3, 2025

Conversation

@veloce
Copy link
Contributor

@veloce veloce commented Feb 28, 2025 •
edited
Loading

Add an EngineEvaluationMixin to share the logic between:

  • analysis controller
  • study controller
  • broadcast analysis controller
  • puzzle controller

veloce added 29 commits February 27, 2025 13:42
@veloce
WIP on refactoring analysis
5f7ed56
@veloce
More wip on refactoring analysis
da9870c
@veloce
More work on engine evaluation mixin
574fa84
@veloce
Do not init engine if not allowed
7e43865
@veloce
Don't send evalGet if not available
c3c816a
@veloce
More work on engine evaluation mixin
c0f6d2e
@veloce
Fix tests
dcb7fb7
@veloce
Simplify evaluation mixin interface
105a0d4
@veloce
Update evaluation mixin interface
41ec07b
@veloce
Don't open socket if analysis is started offline
90fb23f
@veloce
No need to check if request eval is available in the parent
88dad53
@veloce
Refactor EvaluationMixin to support Notifier
bc0bac4
@veloce
Rename field
4acbfa5
@veloce
Fix tests
3754c61
@veloce
Simplify evaluation mixin state interface
1e78485
@veloce
Fix cloud eval socket requests
4fb974f
@veloce
Wait for socket connection before requesting eval
a03fca5
@veloce
Don't override a cloud eval with a local eval
93d0f01
@veloce
Improve engine depth widget
c92c4e9
@veloce
Fix onCurrentPathEvalChanged
5cfa07b
@veloce
Add more engine tests
2252eda
@veloce
Improve engine depth info widget
c4b6053
@veloce
Tweak
e0f179b
@veloce
Add protected annotation to fix lint warning
880ee58
@veloce
Fix request first connection when offline on analysis
c89e6e8
@veloce
Really fix request eval when offline on analysis
386bc62
@veloce
Tweak engine depth
9b21842
@veloce
Refactor engine tests, test cloud eval
65253e5
@veloce
Add more engine tests
ae9b564
@veloce veloce marked this pull request as ready for review March 3, 2025 16:04
@veloce veloce merged commit e2f1439 into main Mar 3, 2025
1 check passed
@veloce veloce deleted the analysis_refactor branch March 3, 2025 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@veloce