Skip to content

fix: prevent move list from resizing when first move is made #1574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 24, 2025
Merged

fix: prevent move list from resizing when first move is made #1574

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 10 additions & 8 deletions lib/src/view/game/game_player.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,9 +152,9 @@ class GamePlayer extends StatelessWidget {
),
if (timeToMove != null)
MoveExpiration(timeToMove: timeToMove!, mePlaying: mePlaying)
else if (materialDiff != null)
else
MaterialDifferenceDisplay(
materialDiff: materialDiff!,
materialDiff: materialDiff,
materialDifferenceFormat: materialDifferenceFormat,
),
// to avoid shifts use an empty text widget
Expand Down Expand Up @@ -322,26 +322,28 @@ class MaterialDifferenceDisplay extends StatelessWidget {
this.materialDifferenceFormat = MaterialDifferenceFormat.materialDifference,
});

final MaterialDiffSide materialDiff;
final MaterialDiffSide? materialDiff;
final MaterialDifferenceFormat? materialDifferenceFormat;

@override
Widget build(BuildContext context) {
final IMap<Role, int> piecesToRender =
(materialDifferenceFormat == MaterialDifferenceFormat.capturedPieces
? materialDiff.capturedPieces
: materialDiff.pieces);
materialDiff != null
? (materialDifferenceFormat == MaterialDifferenceFormat.capturedPieces
? materialDiff!.capturedPieces
: materialDiff!.pieces)
: IMap();

return materialDifferenceFormat?.visible ?? true
? Row(
children: [
for (final role in Role.values)
for (int i = 0; i < piecesToRender[role]!; i++)
for (int i = 0; i < (piecesToRender.get(role) ?? 0); i++)
Icon(_iconByRole[role], size: 13, color: textShade(context, 0.5)),
const SizedBox(width: 3),
Text(
style: TextStyle(fontSize: 13, color: textShade(context, 0.5)),
materialDiff.score > 0 ? '+${materialDiff.score}' : '',
materialDiff != null && materialDiff!.score > 0 ? '+${materialDiff!.score}' : '',
),
],
)
Expand Down