feat: add tournament screen #1583

tom-anders · 2025-03-25T18:36:31Z

With this PR, we'd have very basic support for tournaments. However, the game screen is still missing some features, like berserking, displaying rank, etc. That will be a follow-up PR. Same goes for the "podium" screen for finished tournaments.

I did not add widget tests yet, wanted to get feedback on the layout/design first.

tournament_screen.webm

TODO:

fix tests
fix non started tournament clock display
fix bug when non started tournament doesn't refresh when the countdown reaches 0 (it should refresh and start automatically, currently: it doesn't start and the featured game doesn't work)
[ ]

…rted

teefoox · 2025-03-25T22:33:33Z

The tournament screen is great! Love it.
I think it would be useful to also have the players' recent results (at least the last one) to know if one needs to win one or two games to get the win-streak buff. In an end tournament rush, it can help to make strategic decisions.

veloce · 2025-03-28T08:39:40Z

Nice work on the UI! Will review asap.

veloce

Great work!

lib/src/model/tournament/tournament_controller.dart

lib/src/view/tournament/tournament_screen.dart

This reverts commit a8e71c0.

is disabled - Fix best move arrow shown on analysis screen when engine is disabled - Standardize analysis screen and broadcast game screen code

arrow tests

tom-anders · 2025-03-29T23:29:27Z

Thanks for the review! I added two widgets tests now, let me know if you think there's anything else that should be tested

screen tests

tom-anders · 2025-04-02T21:14:47Z

The server already sends a reload event when something notable changes, so I don't think manual refreshing would have any benefit

Then it needs to register app lifecycle onPause/onResume callbacks to force a reload on resume

Done 👍

But here, we need the tournament socket to stay active. If I delete that linked code, moving to the next game works (but it's probably not the solution we want...?)

indeed it is by design we don't want more than one socket connection at a time; how does it work on the website? I don't think the tournament page opens 2 sockets. IIRC the old mobile app also do not open 2 sockets at the same time and still has the featured game.

Ah, I checked with Firefox devtools, the website sends a startWatching to the server, so we need to do the same. I guess that means we can't reuse the TvController anymore, but that's fine

tom-anders · 2025-04-03T21:10:38Z

test/view/tournament/tournament_screen_test.dart

      ]);
      // wait for socket message
      await tester.pump(const Duration(milliseconds: 10));
-      expect(find.byType(PieceWidget), findsNWidgets(32));


@veloce FYI: After adding the featured game in the tests as well, this expectation failed as it seems to still find the PieceWidgets from the FeatureGame board. So I replaced it with a check to find the name of our opponent instead to verify that the game screen is shown.

@tom-anders you could refine by using find.descendant to check the pieces are descendant of GameScreen.

tom-anders · 2025-04-03T21:11:41Z

Alright, we're using the tournament websocket now for displaying the featured game, now everything works even when there's a new featured game.

I also made the board look more like in broadcasts:

tom-anders · 2025-04-03T21:12:53Z

lib/src/model/tournament/tournament.dart

-    featuredGame: pick('featured').asFeaturedGameOrNull(),
+    // Sometimes a new FEN comes in via the websocket, but the API reload response
+    // still has the FEN of the previous move, leading to sync issues.
+    // So only copy the whole game here if it's a new ID.


Without this logic, I saw some glitches where moves were taken back due to API and websocket being out of sync

Have you checked how it works on the website? Given the reload mechanism I find it strange indeed to use both this and the websocket.

I can check again and/or ask @ornicar, but I think the reload events are not tied to the events of the featured game, but rather to the score/standings changing

No it's fine like that. You need the reload events to know there is a new game. I assume the server sends the reload socket message when a new featured game starts.

Exactly, when there's a new featured game, we get it via reload and then send startWatching via the socket to get the updates for each move

tom-anders · 2025-04-03T21:13:35Z

lib/src/view/tournament/tournament_screen.dart

-        }
+
+        // Don't bother parsing the whole FEN here, we just need the turn
+        final turn = featuredGame.fen.endsWith(' b') ? Side.black : Side.white;


@veloce Does chessground have some kind of convenience API for this? I didn't want to waste performance by parsing the whole string here

Nope. That would be more a dartchess thing but for now there is only the Position API which parses the full fen. I don't think performance is an issue here though, so I wouldn't bother.

Well for bullet games this might be called pretty often

Fen parsing is cheap enough that even for real games (playing), the FEN is parsed each time the position change (it's a chessground parameter).

Alright 👍

Over the board feats: Resign, Offer Draw and notification on threefold repetition

…ess-mobile into tom-anders-tournamentScreen

veloce · 2025-04-04T14:51:45Z

Sorry it messed the PR commit history...

veloce · 2025-04-04T14:53:17Z

Will merge soon I think, still some testing and a couple of UI changes.

andy-ife added 7 commits March 17, 2025 21:41

Replace add icon with menu icon in OverTheBoardScreen BottomBar

b5d07a4

Add OverTheBoard game menu ui

1d643b2

OverTheBoard menu: Implement New game and Flip board functionality

748683d

OverTheBoard menu: Make Draw and Resign visible only when game is sta…

1c062a2

…rted

OverTheBoard menu: Implement Resign and Offer Draw functionality

0d7925f

OverTheBoard: Add notification on threefold repetition

1f39e0c

Add Analysis Board to OverTheBoard menu

9543b9b

tom-anders force-pushed the tournamentScreen branch from daa3a61 to 705f28a Compare March 25, 2025 18:38

feat: add tournament screen

966166c

tom-anders force-pushed the tournamentScreen branch from 705f28a to 966166c Compare March 25, 2025 18:41

veloce reviewed Mar 29, 2025

View reviewed changes

tom-anders and others added 13 commits March 29, 2025 21:56

add player scores

dc0ff22

fix countdown resetting on reload

a1fc2f9

fix typo

85d4f79

don't declare SocketClient field as late final

f7d04af

move ref.dispose to the top

21ad7b0

cancel timer before creating a new one

098405b

Revert "Make clockUpdatedAt param mandatory"

d1a9b48

This reverts commit a8e71c0.

don't set clockUpdatedAt for tournament countdown

058b0d1

refactor verdicts filter

c43cb47

remove redundant GestureDetector

78b00b2

- Fix annotation shown on broadcast game screen when computer analysis

14dedf7

is disabled - Fix best move arrow shown on analysis screen when engine is disabled - Standardize analysis screen and broadcast game screen code

Move best move arrow tests to the engine folder and add news best move

f745121

arrow tests

add widget tests, simplify TournamentController

1880a75

Move best move arrow, engine lines and engine gauge tests to analysis

48ef67f

screen tests

tom-anders mentioned this pull request Mar 29, 2025

feat: add tournament support to game screen #1597

Closed

1 task

Tweak analysis and broadcast board code

7a0d4b8

reload on resume

338c8f1

veloce and others added 11 commits April 3, 2025 11:08

Rename fields and add doc for better clarity

38b48eb

Fix http logs screen

055476a

Remove unused import

041d651

[crash] fix broadcast json decoding where relayPath may be null

f558c8d

Code improvements

de0b10a

Fix non mounted setState

161c6d4

Check if puzzle solution move exists

7a191b4

Upgrade dependencies

0c9c7ad

Upgrade app_settings and flutter_local_notifications

aeaf7f3

More mounted checks

5bf1d9f

use tournament websocket for featured game

2a1b060

tom-anders commented Apr 3, 2025

View reviewed changes

tom-anders and others added 5 commits April 3, 2025 23:46

don't start clocks too early

6e1a1d5

Upgrade dartchess

8e37b42

Merge pull request lichess-org#1571 from andy-ife/over-the-board-feats

30fd0c3

Over the board feats: Resign, Offer Draw and notification on threefold repetition

Merge branch 'tournamentScreen' of https://github.com/tom-anders/lich…

6c3baae

…ess-mobile into tom-anders-tournamentScreen

Tournament screen improvements

204630b

veloce added 5 commits April 7, 2025 15:05

Allow refresh tournament list

1437921

Use a lighter general icon font

8c2214f

Revamp play screen, put online bots in less prominent spot

5fa7037

Revamp tournament screen

3a6e458

Fix lint

a9c6188

veloce merged commit a9c6188 into lichess-org:main Apr 9, 2025
1 check failed

Uh oh!

feat: add tournament screen #1583

feat: add tournament screen #1583

Uh oh!

Conversation

tom-anders commented Mar 25, 2025 • edited by veloce Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

teefoox commented Mar 25, 2025

Uh oh!

veloce commented Mar 28, 2025

Uh oh!

veloce left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tom-anders commented Mar 29, 2025

Uh oh!

tom-anders commented Apr 2, 2025

Uh oh!

tom-anders Apr 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tom-anders commented Apr 3, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

veloce commented Apr 4, 2025

Uh oh!

veloce commented Apr 4, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

tom-anders commented Mar 25, 2025 •

edited by veloce

Loading

tom-anders Apr 3, 2025 •

edited

Loading