Add button to share only game URL #1622
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
veloce
reviewed
Apr 24, 2025
| BottomSheetAction( | ||
| makeLabel: (context) => Text(context.l10n.mobileShareGameURL), | ||
| onPressed: () { | ||
| final boardUrl = lichessUri('/${analysisState.gameId}'); |
There was a problem hiding this comment.
You need to add the orientation of the game: /:gameId/:<black|white>
veloce
approved these changes
May 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the only options for sharing a game URL, from what I can tell are:
I often will want to share a game directly to a friend on Whatsapp for him to view on the website/app so an entire PGN is unnecessary.
This PR adds a new button to share the URL via the share activity directly from the main analysis board menu.